Added schema version detection with schema tag#306
Merged
stevehu merged 1 commit intonetworknt:masterfrom Jun 25, 2020
Merged
Conversation
Some small code clean up
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=========================================
Coverage 70.96% 70.96%
- Complexity 636 643 +7
=========================================
Files 73 74 +1
Lines 2445 2445
Branches 513 515 +2
=========================================
Hits 1735 1735
Misses 506 506
Partials 204 204
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #305
Additional utility to auto detect version. Will make life easier switching between schema versions, by updating schema JSON only, without touching the java code.
Added test cases, as necessary.
Additionally, some small code clean up.