Skip to content

added test schema#274

Merged
stevehu merged 2 commits intonetworknt:masterfrom
francesc79:feature/urn-management
Mar 21, 2020
Merged

added test schema#274
stevehu merged 2 commits intonetworknt:masterfrom
francesc79:feature/urn-management

Conversation

@francesc79
Copy link
Copy Markdown

Check before UrnTest test.
In the test I pass a inputStream to getSchema this means that URIFactory can't determine the relative path. I add the URNFactory for manage that.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 20, 2020

Codecov Report

Merging #274 into master will increase coverage by 0.25%.
The diff coverage is 61.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #274      +/-   ##
============================================
+ Coverage     70.39%   70.65%   +0.25%     
- Complexity      625      631       +6     
============================================
  Files            73       73              
  Lines          2395     2409      +14     
  Branches        509      511       +2     
============================================
+ Hits           1686     1702      +16     
  Misses          503      503              
+ Partials        206      204       -2     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/networknt/schema/RefValidator.java 75.47% <40.00%> (+2.74%) 13.00 <1.00> (+3.00)
...n/java/com/networknt/schema/JsonSchemaFactory.java 76.54% <80.00%> (+1.07%) 27.00 <0.00> (+1.00)
...n/java/com/networknt/schema/ValidationContext.java 76.92% <100.00%> (+1.92%) 11.00 <1.00> (+1.00)
...ava/com/networknt/schema/uri/URISchemeFactory.java 86.20% <0.00%> (+6.89%) 11.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ce67d...8b2dbfd. Read the comment docs.

@stevehu stevehu self-requested a review March 20, 2020 10:51
@stevehu
Copy link
Copy Markdown
Contributor

stevehu commented Mar 20, 2020

This PR is to resolve the issue

@stevehu
Copy link
Copy Markdown
Contributor

stevehu commented Mar 20, 2020

@francesc79 Would you be able to write a small document to show users how to use this feature? I usually add a link in the README.md to link to a document in the doc folder. Thanks.

@stevehu stevehu merged commit 2ef94a1 into networknt:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants