addEdges: remove unnecessary copy on input data #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssary copy on input data.
3facafa to
752ddb8
Compare
Pull Request Test Coverage Report for Build 19029508561Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues raised in #1368. While looking more deeply into the data types used as input in
addEdges, numpy array sizes areint64orint32(platform dependent). SciPy COO matrix rows/columns are either of typeint32orint64, depending on the input size. As a result, the internal data types are changed to signed equivalents, and using views effectively avoids copies of rows/columns from input data.In addition, this adds backward compatibility for
addEdges(and thereforeGraphFromCoo).With this code, the code snippet from #1368 works with NumPy 1.26.4.