helpers.pyx: Fix 32-bit overflow for internal variables #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting 2d ndarrays.
Pull Request Test Coverage Report for Build 18842936563Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1366.
Basically, the
inttype of the internal size counter is degraded to 32 bits. The reported issue can be reproduced (given the code in #1366) on macOS 15.7. With the change, the type is aligned with the return type ofnested.size().size_tis still implementation-defined; however, given the standard, it is at leastunsignedand normally 64 bits on modern machines. With the change, the snippet from the referenced issue now works. The 2D ndarray uses roughly 20 GB of memory.