Skip to content

Conversation

@bernlu
Copy link

@bernlu bernlu commented Feb 6, 2025

fixes #1271

  • there was a bug where the ownership was never set correctly:NetworKit::GlobalState::setRootSet(caller) is the wrong function; it should be setRoot(caller). Because of implicit conversion of pointers to bool we never noticed this bug.
  • additionally, I cleaned up the code a bit to make understanding easier and added some documentation.

@bernlu bernlu force-pushed the fix/signal-handler-resource-leak branch from a4c30f1 to d15bca1 Compare February 7, 2025 10:30
@fabratu fabratu added the bug label Feb 7, 2025
…ler function

additionally, some code cleanup to make structure simpler
@bernlu bernlu force-pushed the fix/signal-handler-resource-leak branch from d15bca1 to f6f8fee Compare February 7, 2025 13:31
@bernlu bernlu requested a review from fabratu February 7, 2025 15:19
@fabratu fabratu merged commit 73bfa1f into networkit:master Feb 18, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server can't be stopped with CTRL+C after using PageRank.run()

2 participants