CI: Split coverage and leak build, fix leaks, remove aarch64 wheel build #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdd9195 to
db6b245
Compare
db6b245 to
15e8108
Compare
2b5a107 to
8160eec
Compare
bernlu
requested changes
Feb 6, 2025
added 11 commits
February 6, 2025 15:27
Adapt topological sorting helper function. GraphTools: Add additional topological sort helper function. Make helper function public in order to avoid possible runtime error. Fix code styling issues in TopologicalSort.hpp.
LouvainMapEquation: Modify string-based constructor to self-initialize datastructures.
Try changing to llvm clang instead of g++ for GCGrowShrink.
…ne_twister_engine.
4e6b416 to
b26ccff
Compare
bernlu
previously approved these changes
Feb 6, 2025
d21e10a to
7e76050
Compare
7e76050 to
44646fc
Compare
bernlu
previously approved these changes
Feb 7, 2025
Member
Author
|
Sry for the drive-by fix, but since the PR is finished and concerned with CI anyways, I added a missing package for the coverage build. |
bernlu
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively fixes the broken coverage upload. Due to also testing for leaks and continuing on errors, the coverage for the C++ code way empty if a potential address leak is found. Both tests are now split into different runs. This should also speedup the coverage run due to having both leak checks and coverage at the same time.
In addition several potential leaks are fixed. One fix in
random.ccfrom libstd is not fixed, since it is intentional. The fix instead is to remove the out-of-bound sanitizer checks for this file by adding a filter.