Fix assignment for Attribute from other Attribute #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dc6176 to
b0e47a3
Compare
added 2 commits
January 16, 2025 10:39
…assignment for const attributes
b0e47a3 to
7b7b0a6
Compare
fabratu
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct assignment of attributes to each other (
attr[i] = attr[j]) previously used the implicitly defined assignment operators forIndexProxywhich do not modify the attribute value. The new implementation withrequiresclauses also ensure that assignment operators aredeletedfor const attributes (the old implementation implicitly defined them).