Skip to content

Conversation

@friedagerharz
Copy link
Collaborator

@friedagerharz friedagerharz commented Sep 24, 2023

Adding a reader for the Matrix Market Format.

  • add tests

@CharJon
Copy link
Contributor

CharJon commented Sep 25, 2023

Hi @friedagerharz , what is the MatrixMarketReader from io/MatrixMarketReader.hpp missing?

@friedagerharz
Copy link
Collaborator Author

friedagerharz commented Sep 25, 2023

Hi @friedagerharz , what is the MatrixMarketReader from io/MatrixMarketReader.hpp missing?

Hi, I created this reader for use with the b-Suitor algorithm (#1109). For this algorithm I need the graph structure in graph/Graph.hpp. Instead of opting to implement a conversion from CSRGeneralMatrix to Graph I decided to implement the reader directly to avoid this extra step.

@CharJon
Copy link
Contributor

CharJon commented Sep 25, 2023

Hi @friedagerharz , what is the MatrixMarketReader from io/MatrixMarketReader.hpp missing?

Hi, I created this reader for use with the b-Suitor algorithm (#1109). For this algorithm I need the graph structure in graph/Graph.hpp. Instead of opting to implement a conversion from CSRGeneralMatrix to Graph I decided to implement the reader directly to avoid this extra step.

Does MatrixTools::matrixToGraph(mat); work for you?

@friedagerharz
Copy link
Collaborator Author

matrixToGraph

Yes, great thank you! Overlooked this function.

@fabratu
Copy link
Member

fabratu commented Sep 27, 2023

@friedagerharz @CharJon While matrixToGraph is a useful function, having a direct reader for a graph data structure saves time and resources. Also, this enables to have the reader in Python directly. I suggest calling the class MatrixMarketGraphReader to distinguish between both variants.

@fabratu
Copy link
Member

fabratu commented Jul 8, 2024

Will close this PR, the functionality will be finalized in PR #1236.

@fabratu fabratu closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants