Add new method SSL.getVersionInt to avoid string allocation on initial ssl handshake#954
Merged
normanmaurer merged 1 commit intonetty:mainfrom Feb 26, 2026
Merged
Conversation
chrisvest
approved these changes
Feb 25, 2026
normanmaurer
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now Netty uses
SSL.getVersion(), which allocates a string when the handshake is finished, we can easily avoid this allocation by introducing a new methodSSL.getVersionInt(), which would return the protocol version as an int instead of a string.Related to netty/netty#16278