Add methods / interfaces to write external SSL_SESSION cache and so b…#548
Merged
normanmaurer merged 4 commits intomasterfrom Jun 4, 2020
Merged
Add methods / interfaces to write external SSL_SESSION cache and so b…#548normanmaurer merged 4 commits intomasterfrom
normanmaurer merged 4 commits intomasterfrom
Conversation
b2af391 to
8465478
Compare
mpenick
reviewed
May 18, 2020
mpenick
reviewed
May 18, 2020
1e0b38f to
326d7bc
Compare
…e able to re-use SSL_SESSION on the client side as well. Motivation: While OpenSSL / BoringSSL / LibreSSL maintain an internal cache for the SSL_SESSIONs on the serverside it needs an external cache for the SSL_SESSION when we want to re-use these on the client side. Modifications: - Add SSLSessionCache interface that can be implemented and so provide an external cache - Add SSLSession class which contains native method definitions to deal with SSL_SESSION - Add other missing methods to SSL and SSLContext (+ the native implementations) Result: Be able to cache SSL_SESSION via an external cache implementation and so reuse SSL_SESSION on the client side as well
326d7bc to
26caa79
Compare
Member
Author
|
@mpenick any other comments ? |
idelpivnitskiy
approved these changes
Jun 2, 2020
Member
idelpivnitskiy
left a comment
There was a problem hiding this comment.
Overall LGTM, but my JNI skills are not trained :)
openssl-dynamic/src/main/java/io/netty/internal/tcnative/SSLSessionCache.java
Outdated
Show resolved
Hide resolved
|
LGTM! |
openssl-dynamic/src/main/java/io/netty/internal/tcnative/SSLSessionCache.java
Outdated
Show resolved
Hide resolved
openssl-dynamic/src/main/java/io/netty/internal/tcnative/SSLSession.java
Show resolved
Hide resolved
carl-mastrangelo
approved these changes
Jun 3, 2020
Member
carl-mastrangelo
left a comment
There was a problem hiding this comment.
Overall looks good. I did have two comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e able to re-use SSL_SESSION on the client side as well.
Motivation:
While OpenSSL / BoringSSL / LibreSSL maintain an internal cache for the SSL_SESSIONs on the serverside it needs an external cache for the SSL_SESSION when we want to re-use these on the client side.
Modifications:
Result:
Be able to cache SSL_SESSION via an external cache implementation and so reuse SSL_SESSION on the client side as well