JNI should load NativeStaticallyReferencedJniMethods before other cla…#245
Closed
Scottmitch wants to merge 1 commit intonetty:masterfrom
Closed
JNI should load NativeStaticallyReferencedJniMethods before other cla…#245Scottmitch wants to merge 1 commit intonetty:masterfrom
Scottmitch wants to merge 1 commit intonetty:masterfrom
Conversation
…sses Motivation: The point of NativeStaticallyReferencedJniMethods is to make JNI values usable in a static context in Java and not worry about cyclic class loading issues. However if we don't explicitly load the NativeStaticallyReferencedJniMethods class from JNI there is a chance another class which statically references a value in NativeStaticallyReferencedJniMethods is loaded first, and creates a circular class loading issue. Modifications: - JNI OnLoad should ensure NativeStaticallyReferencedJniMethods is loaded before other tcnative classes Result: Methods from NativeStaticallyReferencedJniMethods can be used in a static context from Java without cyclic class loading issues.
normanmaurer
approved these changes
Mar 7, 2017
Member
Author
|
master (c1946a8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sses
Motivation:
The point of NativeStaticallyReferencedJniMethods is to make JNI values usable in a static context in Java and not worry about cyclic class loading issues. However if we don't explicitly load the NativeStaticallyReferencedJniMethods class from JNI there is a chance another class which statically references a value in NativeStaticallyReferencedJniMethods is loaded first, and creates a circular class loading issue.
Modifications:
Result:
Methods from NativeStaticallyReferencedJniMethods can be used in a static context from Java without cyclic class loading issues.