Avoid wrapping scheduled Runnables in Callable adapter#9666
Merged
normanmaurer merged 2 commits intonetty:4.1from Oct 17, 2019
Merged
Avoid wrapping scheduled Runnables in Callable adapter#9666normanmaurer merged 2 commits intonetty:4.1from
normanmaurer merged 2 commits intonetty:4.1from
Conversation
Motivation Currently when future tasks are scheduled via schedule(Runnable, ...) methods, the supplied Runnable is wrapped in a newly allocated Callable adapter prior to being wrapped in a ScheduledFutureTask. This can be avoided which saves an object allocation per scheduled task. Modifications Change the Callable task field of ScheduledFutureTask to be of type Object so that it can hold/run Runnables directly in addition to Callables. An "adapter" is still used in the case a Runnable is scheduled with an explicit constant non-null completion value, assumed to be rare. Result Less garbage
|
Can one of the admins verify this patch? |
Member
|
@netty-bot test this please |
normanmaurer
approved these changes
Oct 16, 2019
Member
|
@netty-bot test this please |
Member
|
@njhill thanks a lot! I also did mark it for "needs back port". Please check if this applicable and if so do it once you have cycles :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when future tasks are scheduled via
schedule(Runnable, ...)methods, the suppliedRunnableis wrapped in a newly allocatedCallableadapter prior to being wrapped in aScheduledFutureTask.This can be avoided which saves an object allocation per scheduled task.
Modifications
Change the
Callable taskfield ofScheduledFutureTaskto be of typeObjectso that it can hold/runRunnables directly in addition toCallables.An "adapter" is still used in the case a
Runnableis scheduled with an explicit constant non-null completion value, assumed to be rare.Result
Less garbage