Simplify ByteBufInputStream.readLine() logic#8380
Merged
normanmaurer merged 1 commit intonetty:4.1from Oct 13, 2018
Merged
Conversation
Motivation: While looking at the nice optimization done in netty#8347 I couldn't help noticing the logic could be simplified further. Apologies if this is just my OCD and inappropriate! Modifications: Reduce amount of code used for ByteBufInputStream.readLine() Result: Slightly smaller and simpler code
|
Can one of the admins verify this patch? |
Member
|
@franz1981 can you check |
Contributor
|
It looks fine to me! |
Member
|
@netty-bot test this please |
normanmaurer
approved these changes
Oct 12, 2018
Member
|
@njhill thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
While looking at the nice optimization done in #8347 I couldn't help noticing that the logic could be simplified further. Apologies if this is just my OCD and inappropriate for a PR!
Modifications:
Reduce amount of code used for
ByteBufInputStream.readLine()Result:
Slightly smaller and simpler code