Cleanup: deprecate IntegerHolder for removal#8339
Merged
normanmaurer merged 1 commit intonetty:4.1from Oct 11, 2018
doom369:deprecate_integer_holder
Merged
Cleanup: deprecate IntegerHolder for removal#8339normanmaurer merged 1 commit intonetty:4.1from doom369:deprecate_integer_holder
normanmaurer merged 1 commit intonetty:4.1from
doom369:deprecate_integer_holder
Conversation
|
Can one of the admins verify this patch? |
Member
|
@netty-bot test this please |
normanmaurer
approved these changes
Oct 11, 2018
Member
|
@doom369 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Seems like
IntegerHolder counterHashCodefield is the very old legacy field that is no longer used. Should be marked as deprecated and removed in the future versions.Modification:
IntegerHolderclass,InternalThreadLocalMap.counterHashCode()andInternalThreadLocalMap.setCounterHashCode(IntegerHolder counterHashCode)are now deprecated.