Ensure ByteToMessageDecoder.Cumulator implementations always release …#8325
Merged
normanmaurer merged 1 commit into4.1from Sep 27, 2018
Merged
Ensure ByteToMessageDecoder.Cumulator implementations always release …#8325normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
njhill
reviewed
Sep 26, 2018
Member
njhill
left a comment
There was a problem hiding this comment.
@normanmaurer I noticed couple of small things...
| composite.addComponent(true, cumulation); | ||
| } | ||
| composite.addComponent(true, in); | ||
| releaseIn = false; |
Member
Author
There was a problem hiding this comment.
good point... lets do it.
| buffer.writeBytes(in); | ||
| return buffer; | ||
| } finally { | ||
| // We most release in in all cases as otherwise it may produce a leak if writeBytes(...) throw |
…in buffer. Motivation: We need to ensure the Cumulator always releases the input buffer if it can not take over the ownership of it as otherwise it may leak. Modifications: - Correctly ensure the buffer is always released. - Add unit tests. Result: Ensure buffer is always released.
abe5ef3 to
61cf9d9
Compare
Member
Author
|
@njhill thanks for the review.. done :) |
trustin
approved these changes
Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in buffer.
Motivation:
We need to ensure the Cumulator always releases the input buffer if it can not take over the ownership of it as otherwise it may leak.
Modifications:
Result:
Ensure buffer is always released.