Use AuthoritativeDnsServerCache for creating the new redirect stream.#8316
Merged
normanmaurer merged 2 commits into4.1from Sep 27, 2018
Merged
Use AuthoritativeDnsServerCache for creating the new redirect stream.#8316normanmaurer merged 2 commits into4.1from
normanmaurer merged 2 commits into4.1from
Conversation
Motivation: At the moment if a user wants to provide custom sorting of the nameservers used for redirects it needs to be implemented in two places. This is more complicated as it needs to be. Modifications: - Just delegate to the AuthoritativeDnsServerCache always as we fill it before we call newRedirectDnsServerStream anyway. Result: Easier way for the user to implement custom sorting.
trustin
reviewed
Sep 27, 2018
| DnsServerAddressStream cached = authoritativeDnsServerCache().get(hostname); | ||
| if (cached == null || cached.size() == 0) { | ||
| // If there is not cache hit (which may be the case for example when a NoopAuthoritativeDnsServerCache | ||
| // is used we will just directly use the provided nameservers. |
Member
There was a problem hiding this comment.
Missing closing parenthesis and comma before 'we will'. i.e. is used), we will
Member
Author
There was a problem hiding this comment.
Yep... anything else?
Member
Author
|
@trustin addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
At the moment if a user wants to provide custom sorting of the nameservers used for redirects it needs to be implemented in two places. This is more complicated as it needs to be.
Modifications:
Result:
Easier way for the user to implement custom sorting.