Fix incorrectly encoded empty SOCKS5 address#8292
Merged
normanmaurer merged 1 commit intonetty:4.1from Sep 18, 2018
Merged
Conversation
a19edca to
53abcce
Compare
If you encode a SOCKS5 message like 'new DefaultSocks5CommandResponse(FAILURE, DOMAIN, "", 0)' you correctly get a result of '05010003000000'. But if the 'bndAddr' is 'null', for example like 'new DefaultSocks5CommandResponse(FAILURE, DOMAIN)' the encoded result is '0501000301000000' which means the domain name has a length of one and consists of a 0-byte. With this commit it is also correctly encoded as a string of 0 length.
53abcce to
d5a9dd2
Compare
Member
|
@Vampire can you please sign our ICLA and let me know once done ? |
Contributor
Author
|
Done |
Member
|
@Vampire merged... thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
If you encode a SOCKS5 message like
new DefaultSocks5CommandResponse(FAILURE, DOMAIN, "", 0)you correctly get a result of
05010003000000.But if the
bndAddrisnull, for example likenew DefaultSocks5CommandResponse(FAILURE, DOMAIN)the encoded result is
0501000301000000which means the domain name has a length of one and consists of a 0-byte.Modification:
With this commit it is also correctly encoded as a string of 0 length.