Skip to content

Implemented ExtendedOpenSslSession.getStatusResponses() so it not thr…#8290

Merged
normanmaurer merged 1 commit into4.1from
extended_openssl_session_java9
Sep 14, 2018
Merged

Implemented ExtendedOpenSslSession.getStatusResponses() so it not thr…#8290
normanmaurer merged 1 commit into4.1from
extended_openssl_session_java9

Conversation

@normanmaurer
Copy link
Copy Markdown
Member

…ows an UnsupportedOperationException.

Motivation:

6ed7c6c added support for ExtendedOpenSslSession but we did not override getStatusResponses(). This lead to test failures on java9.

Modifications:

Implement ExtendedOpenSslSession.getStatusResponses() so it just returns an empty list.

Result:

Test pass again on Java9.

…ows an UnsupportedOperationException.

Motivation:

6ed7c6c added support for ExtendedOpenSslSession but we did not override getStatusResponses(). This lead to test failures on java9.

Modifications:

Implement ExtendedOpenSslSession.getStatusResponses() so it just returns an empty list.

Result:

Test pass again on Java9.
@normanmaurer
Copy link
Copy Markdown
Member Author

I did not notice this as it only happens on Java9 and I would even argue that this may be a bug.

Copy link
Copy Markdown
Member

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@normanmaurer normanmaurer merged commit 34d52fc into 4.1 Sep 14, 2018
@normanmaurer normanmaurer deleted the extended_openssl_session_java9 branch September 14, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants