Fix get charset from content-type header with multiple parameters, cl…#8286
Merged
normanmaurer merged 2 commits intonetty:4.1from Sep 14, 2018
Merged
Fix get charset from content-type header with multiple parameters, cl…#8286normanmaurer merged 2 commits intonetty:4.1from
normanmaurer merged 2 commits intonetty:4.1from
Conversation
normanmaurer
requested changes
Sep 14, 2018
Member
normanmaurer
left a comment
There was a problem hiding this comment.
two nits... then good to go.
| int indexOfSemicolon = AsciiString.indexOfIgnoreCaseAscii(charsetCandidate, SEMICOLON, 0); | ||
| if (indexOfSemicolon == AsciiString.INDEX_NOT_FOUND) { | ||
| return charsetCandidate; | ||
| } else { |
Member
There was a problem hiding this comment.
nit: You can remove the else here as you return in the if block.
| public static boolean isKeepAlive(HttpMessage message) { | ||
| CharSequence connection = message.headers().get(HttpHeaderNames.CONNECTION); | ||
| if (connection != null && HttpHeaderValues.CLOSE.contentEqualsIgnoreCase(connection)) { | ||
| if (HttpHeaderValues.CLOSE.contentEqualsIgnoreCase(connection)) { |
Member
There was a problem hiding this comment.
@amizurov can you add comment that passing null into contentEqualsIngoreCase is fine ?
Contributor
Author
There was a problem hiding this comment.
If we passed null to contentEqulasIgnoreCase(...) this always return false, null safe method.
normanmaurer
approved these changes
Sep 14, 2018
Member
|
@amizurov thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close Resolve charset from ContentType header for SOAP 1.2 requests.
Motivation:
Get charset from Content-Type header even it contains multiple parameters.
Modification:
Extract charset value from the charset parameter if it is not last.
Result:
Fixes #8273