Return an ExtendSSLSession whenever possible to allow more strict che…#8281
Merged
normanmaurer merged 1 commit into4.1from Sep 14, 2018
Merged
Return an ExtendSSLSession whenever possible to allow more strict che…#8281normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
carl-mastrangelo
approved these changes
Sep 11, 2018
| Assert.assertNotNull(session); | ||
| if (session instanceof ExtendedSSLSession) { | ||
| ExtendedSSLSession extendedSSLSession = (ExtendedSSLSession) session; | ||
| List<SNIServerName> names = extendedSSLSession.getRequestedServerNames(); |
02ea06b to
99f936d
Compare
…cking when using OpenSSL Motivation: When an ExtendedSSLSession is used its possible to do more strict checking of the keys during handshake. We should do this whenever possible. Modification: - Return an ExtendedSSLSession when using client-mode and Java7+ - Add unit test - Simplify unit tests Result: More consistent behaviour.
99f936d to
0143695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cking when using OpenSSL
Motivation:
When an ExtendedSSLSession is used its possible to do more strict checking of the keys during handshake. We should do this whenever possible.
Modification:
Result:
More consistent behaviour.