Do not log explicit no unsafe, fixes helper method.#8111
Merged
normanmaurer merged 1 commit intonetty:4.1from Jul 9, 2018
Merged
Do not log explicit no unsafe, fixes helper method.#8111normanmaurer merged 1 commit intonetty:4.1from
normanmaurer merged 1 commit intonetty:4.1from
Conversation
Motivation: Users should not see a scary log message when Netty is initialized if Netty configuration explicitly disables unsafe. The log message that produces this warning was previously guarded but by recent refactoring a bug was introduced inside the guard helper method. Modifications: This commit brings back the guard against the scary log message if unsafe is explicitly disabled. Result: No log message is produced when unsafe is unavailable because Netty was told to not look for it. Relates netty#5624, netty#6696
Contributor
Author
|
@jasontedor I hope you don't mind that I've re-used your PR/commit message ;) |
Contributor
|
@seut I don’t mind at all, thank you for fixing this. I had noticed a few weeks ago this was broken again and haven’t taken the time yet to submit a PR so I’m super thankful that you did! ❤️ |
normanmaurer
approved these changes
Jul 9, 2018
Member
|
@seut doh... thanks a lot ! |
Contributor
Author
|
@normanmaurer thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Users should not see a scary log message when Netty is initialized if
Netty configuration explicitly disables unsafe. The log message that
produces this warning was previously guarded but by recent refactoring
a bug was introduced inside the guard helper method.
Modifications:
This commit brings back the guard against the scary log message if
unsafe is explicitly disabled.
Result:
No log message is produced when unsafe is unavailable because Netty was
told to not look for it.
Relates #5624, #6696