FastThreadLocal#set remove duplicate isIndexedVariableSet call#7541
Merged
Scottmitch merged 1 commit intonetty:4.1from Dec 22, 2017
Merged
FastThreadLocal#set remove duplicate isIndexedVariableSet call#7541Scottmitch merged 1 commit intonetty:4.1from
Scottmitch merged 1 commit intonetty:4.1from
Conversation
Motivation: FastThreadLocal#set calls isIndexedVariableSet to determine if we need to register with the cleaner, but the set(InternalThreadLocalMap, V) method will also internally do this check so we can share code and only do the check a single time. Modifications: - extract code from set(InternalThreadLocalMap, V) so it can be called externally to determine if a new item was created Result: Less code duplication in FastThreadLocal#set.
1687144 to
47f8aae
Compare
normanmaurer
approved these changes
Dec 22, 2017
Member
normanmaurer
left a comment
There was a problem hiding this comment.
Merge once green... LGTM!
Thanks buddy
Member
Author
|
4.0 (f8a0eea) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
FastThreadLocal#set calls isIndexedVariableSet to determine if we need to register with the cleaner, but the set(InternalThreadLocalMap, V) method will also internally do this check so we can share code and only do the check a single time.
Modifications:
Result:
Less code duplication in FastThreadLocal#set.