HttpObjectDecoder skips arbitrary initial control characters when only initial CRLF characters are permitted (#16861)#16863
Merged
Merged
Conversation
…y initial CRLF characters are permitted (#16861) Motivation: RFC 9112 permit empty lines (CR LF sequences) prior to the request line, but we were skipping over any ISO control characters. This is parsing leniency beyond what the standard mandates and can be a security liability. Modification: Expand the scope of the "strict line parsing" decoder configuration option to also include enforcing that any octets prior to the initial line can only be the line separators CR LF. Result: Strict line parsing covers more cases. Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
RFC 9112 permit empty lines (CR LF sequences) prior to the request line,
but we were skipping over any ISO control characters.
This is parsing leniency beyond what the standard mandates and can be a
security liability.
Modification:
Expand the scope of the "strict line parsing" decoder configuration
option to also include enforcing that any octets prior to the initial
line can only be the line separators CR LF.
Result:
Strict line parsing covers more cases.
Co-authored-by: Chris Vest christianvest_hansen@apple.com