Isolate tests that modify available Security providers (#16793)#16805
Merged
Conversation
Motivation: The `java.security.Security` providers list is a JVM-wide shared resource, and modifying the list at runtime can lead to problems where a provider that was available previously is suddenly removed. This can lead to `NoSuchAlgorithmException` and other issues, manifesting as flaky tests. Modification: Find all tests that modify the `Security` providers list, and make sure they're all `@Isolated`. Result: Less flaky build. (cherry picked from commit 4e578fc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The
java.security.Securityproviders list is a JVM-wide shared resource, and modifying the list at runtime can lead to problems where a provider that was available previously is suddenly removed. This can lead toNoSuchAlgorithmExceptionand other issues, manifesting as flaky tests.Modification:
Find all tests that modify the
Securityproviders list, and make sure they're all@Isolated.Result:
Less flaky build.
(cherry picked from commit 4e578fc)