Auto-port 5.0: Remove dead native declarations#16786
Merged
Merged
Conversation
Motivation: `ssizeMax`, `iovMax`, `uioMaxIov` are declared native in the epoll `NativeStaticallyReferencedJniMethods` but never added to the epoll RegisterNatives table Runtime Impact: None — these three methods are never invoked from the epoll class; they are dead native declarations Modification: Remove `ssizeMax`, `iovMax`, and `uioMaxIov` from `NativeStaticallyReferencedJniMethods.java` in the `epoll` package — they are unreachable dead code that causes false positives in bytecode analysis Result: Fixes #16757 If there is no issue then describe the changes introduced by this PR. (cherry picked from commit 596be74)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16783 to 5.0
Cherry-picked commit: 596be74
Motivation:
ssizeMax,iovMax,uioMaxIovare declared native in the epollNativeStaticallyReferencedJniMethodsbut never added to the epoll RegisterNatives tableRuntime Impact:
None — these three methods are never invoked from the epoll class; they are dead native declarations
Modification:
Remove
ssizeMax,iovMax, anduioMaxIovfromNativeStaticallyReferencedJniMethods.javain theepollpackage — they are unreachable dead code that causes false positives in bytecode analysisResult:
Fixes #16757
If there is no issue then describe the changes introduced by this PR.