Skip to content

Quic: Ensure writes are done before notify close promise of QuicheQui…#16760

Merged
normanmaurer merged 2 commits into
5.0from
q_fix5
May 10, 2026
Merged

Quic: Ensure writes are done before notify close promise of QuicheQui…#16760
normanmaurer merged 2 commits into
5.0from
q_fix5

Conversation

@normanmaurer

Copy link
Copy Markdown
Member

…… (#16758)

…cChannel

Motivation:

We need to ensure the writes are actually done before we notify the close promise as otherwise the user might close the parent socket while things are still infligth and so the remote peer will not receive the close frame.

Modifications:

  • Ensure writes are done before we actually notify the close promise
  • Add unit test that simulates delay of writes and the raced close

Result:

Fixes #16718

#16758)

…cChannel

Motivation:

We need to ensure the writes are actually done before we notify the
close promise as otherwise the user might close the parent socket while
things are still infligth and so the remote peer will not receive the
close frame.

Modifications:

- Ensure writes are done before we actually notify the close promise
- Add unit test that simulates delay of writes and the raced close

Result:

Fixes #16718

Co-authored-by: Thomas Segismont <tsegismo@ibm.com>
@chrisvest chrisvest enabled auto-merge (squash) May 9, 2026 21:47
@normanmaurer normanmaurer disabled auto-merge May 10, 2026 06:16
@normanmaurer normanmaurer merged commit d810e99 into 5.0 May 10, 2026
12 of 13 checks passed
@normanmaurer normanmaurer deleted the q_fix5 branch May 10, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants