Quic: Ensure writes are done before notify close promise of QuicheQui…#16760
Merged
Conversation
#16758) …cChannel Motivation: We need to ensure the writes are actually done before we notify the close promise as otherwise the user might close the parent socket while things are still infligth and so the remote peer will not receive the close frame. Modifications: - Ensure writes are done before we actually notify the close promise - Add unit test that simulates delay of writes and the raced close Result: Fixes #16718 Co-authored-by: Thomas Segismont <tsegismo@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#16758)
…cChannel
Motivation:
We need to ensure the writes are actually done before we notify the close promise as otherwise the user might close the parent socket while things are still infligth and so the remote peer will not receive the close frame.
Modifications:
Result:
Fixes #16718