Auto-port 5.0: Fix io_uring op completion TRACE logging#16756
Merged
Conversation
Motivation: Completions accidentally used the `short data` instead of the `int id` of the user-data when TRACE logging. This means we cannot tell from a completion what file descriptor it belongs to. Modification: Log the `id` instead. Result: We can now tell what file descriptor a completion belongs to when we TRACE log the io_uring transport. (cherry picked from commit 93c5a40)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16755 to 5.0
Cherry-picked commit: 93c5a40
Motivation:
Completions accidentally used the
short datainstead of theint idof the user-data when TRACE logging. This means we cannot tell from a completion what file descriptor it belongs to.Modification:
Log the
idinstead.Result:
We can now tell what file descriptor a completion belongs to when we TRACE log the io_uring transport.