Conversation
Motivation: KQueue event registrations are set on file descriptors. When a channel is deregistered, we need to remove the filters to avoid them triggering on future reuses of the same file descriptor. However, this deregistering was done _after_ the file descriptor had been closed, which means we had a race where it could be reused and registered to a channel, and _then_ we cleared the filters. Modification: Move the `doDeregister()` to `doClose()` in `AbstractKQueueChannel` and remove the `prepareToClose` machinery that was only used when SO_LINGER had been configured. Result: More stable kqueue integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
KQueue event registrations are set on file descriptors. When a channel
is deregistered, we need to remove the filters to avoid them triggering
on future reuses of the same file descriptor. However, this
deregistering was done after the file descriptor had been closed,
which means we had a race where it could be reused and registered to a
channel, and then we cleared the filters.
Modification:
Move the
doDeregister()todoClose()inAbstractKQueueChannelandremove the
prepareToClosemachinery that was only used when SO_LINGERhad been configured.
Result:
More stable kqueue integration.