Auto-port 5.0: Use stream error for maxContentLength exceeded in InboundHttp2ToHttpAdapter#16628
Merged
Conversation
…dapter (#16558) Motivation: When a message payload exceeds `maxContentLength` in `InboundHttp2ToHttpAdapter`, a connection error (`INTERNAL_ERROR`) is thrown. This sends a GOAWAY frame that closes the entire HTTP/2 connection, affecting all concurrent streams. Load balancers often treat GOAWAY as a 5xx error, even though this is a client-side issue (sending a payload that is too large). Exceeding the content length for a single stream should only affect that stream. Modification: Changed the error from `connectionError(INTERNAL_ERROR)` to `streamError(streamId, ENHANCE_YOUR_CALM)` in `onDataRead()`. The `ENHANCE_YOUR_CALM` error code is semantically appropriate for resource limit violations per RFC 7540 Section 7. Added test `exceedMaxContentLengthShouldCauseStreamErrorNotConnectionError()` that sends oversized data on stream 3 and verifies: - A `StreamException` (not connection error) is produced - The error targets stream 3 with `ENHANCE_YOUR_CALM` error code - The test correctly fails when the fix is reverted Result: Fixes #11994. (cherry picked from commit d8dd805)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16558 to 5.0
Cherry-picked commit: d8dd805
Motivation:
When a message payload exceeds
maxContentLengthinInboundHttp2ToHttpAdapter, a connection error (INTERNAL_ERROR) is thrown. This sends a GOAWAY frame that closes the entire HTTP/2 connection, affecting all concurrent streams. Load balancers often treat GOAWAY as a 5xx error, even though this is a client-side issue (sending a payload that is too large). Exceeding the content length for a single stream should only affect that stream.Modification:
Changed the error from
connectionError(INTERNAL_ERROR)tostreamError(streamId, ENHANCE_YOUR_CALM)inonDataRead(). TheENHANCE_YOUR_CALMerror code is semantically appropriate for resource limit violations per RFC 7540 Section 7.Added test
exceedMaxContentLengthShouldCauseStreamErrorNotConnectionError()that sends oversized data on stream 3 and verifies:StreamException(not connection error) is producedENHANCE_YOUR_CALMerror codeResult:
Fixes #11994.