Auto-port 5.0: Epoll: Cleanup code to always return negative value on failure#16600
Merged
Conversation
Motivation: We usually use a negative value in case of an error but did not in one case. While this does not really matters in practise as weput an exception on the call stack we should be consistent. Modifications: Return negative value on fcntl failure Result: More consistent code base (cherry picked from commit ec36e8c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16591 to 5.0
Cherry-picked commit: ec36e8c
Motivation:
We usually use a negative value in case of an error but did not in one case. While this does not really matters in practise as weput an exception on the call stack we should be consistent.
Modifications:
Return negative value on fcntl failure
Result:
More consistent code base