Auto-port 4.1: Fix parsing HTTP chunks with multiple extensions#16588
Merged
Conversation
Motivation: The chunk extension parsing/validation logic did not correctly account for extensions with multiple key-value pairs. Modification: - Adapt parsing logic to accept the repeatability of extension key-value pairs, and that chunk extensions can end on unquoted value tokens. - Add tests to capture these cases. Result: More correct HTTP chunk extension parsing. The tests are lifted from #16542 Co-authored-by: Norman Maurer <norman_maurer@apple.com> (cherry picked from commit b2c0dfd)
|
Please merge this patch and re-release. I am seeing that 4.1.132.Final is still vulnerable. |
Ignore me, it's still possible to pipeline, but not to smuggle. Should be fine. My apologies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16579 to 4.1
Cherry-picked commit: b2c0dfd
Motivation:
The chunk extension parsing/validation logic did not correctly account for extensions with multiple key-value pairs.
Modification:
Result:
More correct HTTP chunk extension parsing.
The tests are lifted from #16542