Auto-port 5.0: Ensure the CRYPTO_BUFFER_POOL is also freed when we fail creating the SSLContext#16567
Merged
Merged
Conversation
… SSLContext (#16545) Motivation: We did miss to also free the CRYPTO_BUFFER_POOL on cause of failure and so could leak native memory in some cases Modifications: Extract CRYPTO_BUFFER_POOL from the SSL_CTX and free it if needed while handling the failure case Result: No CRYPTO_BUFFER_POOL leak anymore in case of failure (cherry picked from commit a5a96e8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16545 to 5.0
Cherry-picked commit: a5a96e8
Motivation:
We did miss to also free the CRYPTO_BUFFER_POOL on cause of failure and so could leak native memory in some cases
Modifications:
Extract CRYPTO_BUFFER_POOL from the SSL_CTX and free it if needed while handling the failure case
Result:
No CRYPTO_BUFFER_POOL leak anymore in case of failure