Auto-port 5.0: Fix implementation of strerror_r_xsi for GNU#16562
Merged
Conversation
Motivation: We did not clear errno before calling strerror_r(...) and then later use it to detect if there was an error. This could lead to false-positives as strerror_r(...) does not set errno to 0 on success. Modifications: Set errno to 0 before calling strerror_r Result: Correct implement strerror_r_xsi for GNU (cherry picked from commit 1fda0d5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16546 to 5.0
Cherry-picked commit: 1fda0d5
Motivation:
We did not clear errno before calling strerror_r(...) and then later use it to detect if there was an error. This could lead to false-positives as strerror_r(...) does not set errno to 0 on success.
Modifications:
Set errno to 0 before calling strerror_r
Result:
Correct implement strerror_r_xsi for GNU