Auto-port 5.0: Kqueue: sendfile EINTR doesn't advance offset — data duplication#16553
Merged
Conversation
) Motivation: BSD/macOS sendfile passes the offset by value (unlike Linux which takes off_t*). When interrupted (EINTR), sbytes reports how many bytes were sent before the signal. Modifications: - Advance off so the next iteration resumes from where we left off, not from the start. Result: Fix possible data corruption when using sendfile and EINTR is observed (cherry picked from commit 55a27f5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16544 to 5.0
Cherry-picked commit: 55a27f5
Motivation:
BSD/macOS sendfile passes the offset by value (unlike Linux which takes off_t*).
When interrupted (EINTR), sbytes reports how many bytes were sent before the signal.
Modifications:
Result:
Fix possible data corruption when using sendfile and EINTR is observed