Open
Conversation
normanmaurer
requested changes
Mar 25, 2026
chrisvest
approved these changes
Mar 25, 2026
Member
|
Putting this one on hold for #16550 — after 4.2.12 we can bring back the optimization and merge this fix. |
Motivation: In certain scenarios, the findComponentForRead fast path would pick the wrong component for a reader index, leading to out-of-bounds reads for those components. Modification: Correct comparison. Result: No incorrect read.
8de55d8 to
e1fcbbc
Compare
Member
|
I rebased this PR with a reapply of the opt change underneath. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In certain scenarios, the findComponentForRead fast path would pick the wrong component for a reader index, leading to out-of-bounds reads for those components.
Modification:
Correct comparison.
Result:
No incorrect read.