Auto-port 5.0: Eliminate redundant bounds checks in CompositeByteBuf accessors#16534
Merged
normanmaurer merged 1 commit into5.0from Mar 24, 2026
Merged
Auto-port 5.0: Eliminate redundant bounds checks in CompositeByteBuf accessors#16534normanmaurer merged 1 commit into5.0from
normanmaurer merged 1 commit into5.0from
Conversation
Motivation: Every _getXxx/_setXxx in CompositeByteBuf delegates to the underlying buffer's public API (e.g. c.buf.getByte()), which re-checks bounds that the composite level already validated. Modifications: - Add an `abuf` field to Component that caches `(AbstractByteBuf) buf` at construction time, or null for non-AbstractByteBuf wrappers - Use abuf._getXxx() (no bounds check) when available, fall back to buf.getXxx() otherwise - Add sequentialReadBytes and sequentialGetBytes JMH benchmarks Result: Redundant bounds checks eliminated on the hot path. (cherry picked from commit 6001499)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16525 to 5.0
Cherry-picked commit: 6001499
Motivation:
Every _getXxx/_setXxx in CompositeByteBuf delegates to the underlying buffer's public API (e.g. c.buf.getByte()), which re-checks bounds that the composite level already validated.
Modifications:
abuffield to Component that caches(AbstractByteBuf) bufat construction time, or null for non-AbstractByteBuf wrappersResult:
Redundant bounds checks eliminated on the hot path.