Auto-port 5.0: Fix pooled arena accounting tests #16325
Merged
Conversation
Motivation: These tests were often running into timeouts. Modification: Capture the stack trace of the spawned thread, and include it in the tests own InterruptedException. Also capture any exceptions thrown in the thread, by wrapping the work in a FutureTask. This makes diagnosing these issues easier. Extend the timeouts to 10 seconds. Give the pool a direct arena since it allocates direct buffers. Without a direct arena, it would allocate unpooled buffers, which bear the cost of deallocation directly in ByteBuf.release. Result: More stable build. (cherry picked from commit fdb2a7b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16321 to 5.0
Cherry-picked commit: fdb2a7b
Motivation:
These tests were often running into timeouts.
Modification:
Capture the stack trace of the spawned thread, and include it in the tests own InterruptedException. Also capture any exceptions thrown in the thread, by wrapping the work in a FutureTask.
This makes diagnosing these issues easier.
Extend the timeouts to 10 seconds.
Give the pool a direct arena since it allocates direct buffers.
Without a direct arena, it would allocate unpooled buffers, which bear the cost of deallocation directly in ByteBuf.release.
Result:
More stable build.