Auto-port 5.0: Fix flaky PooledByteBufAllocatorTest#16323
Merged
Conversation
Motivation: We observed the testThreadCacheDestroyedByThreadCleaner test failing due to timing out after 10 seconds, while in the `runFinalization` call. After analyzing the code, I've determined that the most likely cause is that the `runFinalization` call itself is very slow, because it waits for the processing of _all_ eligible finalizers, rather than just the one we care about. Modification: - Remove the call to `runFinalization` and instead rely on the background reference processing thread. - Increase the timeout from 10 to 20 seconds, to account for a busier runtime environment now that we run all the buffer tests in parallel. Result: More stable build, hopefully. (cherry picked from commit 1e78d3f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16313 to 5.0
Cherry-picked commit: 1e78d3f
Motivation:
We observed the testThreadCacheDestroyedByThreadCleaner test failing due to timing out after 10 seconds, while in the
runFinalizationcall.After analyzing the code, I've determined that the most likely cause is that the
runFinalizationcall itself is very slow, because it waits for the processing of all eligible finalizers, rather than just the one we care about.Modification:
runFinalizationand instead rely on the background reference processing thread.Result:
More stable build, hopefully.