Fix IDE warnings in SslHandler (#16237)#16299
Merged
Conversation
Motivation: Make code cleaner and easier to read. Modification: - Use lambdas/method references when possible - Removed unreachable condition `result.bytesConsumed() == 0 && result.getHandshakeStatus() == HandshakeStatus.NOT_HANDSHAKING` as previously in the code there is a switch that returns true for `NOT_HANDSHAKING` status - Remove unnecessary `result.bytesConsumed()` call Result: Less IDE warnings, easier to read code --------- Co-authored-by: Chris Vest <christianvest_hansen@apple.com> (cherry picked from commit 5ed3065)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Make code cleaner and easier to read.
Modification:
result.bytesConsumed() == 0 && result.getHandshakeStatus() == HandshakeStatus.NOT_HANDSHAKINGas previously in the code there is a switch that returns true forNOT_HANDSHAKINGstatusresult.bytesConsumed()callResult:
Less IDE warnings, easier to read code
Co-authored-by: Chris Vest christianvest_hansen@apple.com
(cherry picked from commit 5ed3065)