Backport 4.1: Some polishing of the porting workflows#16292
Merged
Conversation
Motivation: Step failures should be reported by the netty project bot instead of the github actions bot. We should also prevent steps from triggering from future label changes by having the workflows remove their triggering label once they're done. Modification: - Make errors be reported through the PAT token so they show as being from the netty project bot. - Make the workflow remove the triggering label if it succeeds in creating a back/forward port PR. - Only attempt to delete the porting branch on failure, if a porting branch was created. - Only report errors for steps that actually failed, i.e. don't report errors for steps that were skipped due to earlier failures. Result: More robust experience with automated backporting. (cherry picked from commit 85d50c6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16288 to 4.1
Cherry-picked commit: 85d50c6
Motivation:
Step failures should be reported by the netty project bot instead of the github actions bot. We should also prevent steps from triggering from future label changes by having the workflows remove their triggering label once they're done.
Modification:
Result:
More robust experience with automated backporting.