Forward port 5.0: Remove the unpooled allocator from test permutations#16289
Merged
Forward port 5.0: Remove the unpooled allocator from test permutations#16289
Conversation
Motivation: The unpooled allocator will allocate and deallocate memory for each buffer, rather than pool the memory. On Java 25+, deallocating memory (in the form of shared memory segments) involves thread-local handshakes, and can have significant overhead to the point of causing frequent test timeouts. Additionally, having the unpooled allocator in the test permutations does not add very much to test coverage. Modification: Remove the unpooled allocator from the transport test permutation parameters. Result: Much faster builds, from removing the overhead of releasing millions of shared memory segments. (cherry picked from commit 8987ec5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of #16282 to 5.0
Cherry-picked commit: 8987ec5
Motivation:
The unpooled allocator will allocate and deallocate memory for each buffer, rather than pool the memory. On Java 25+, deallocating memory (in the form of shared memory segments) involves thread-local handshakes, and can have significant overhead to the point of causing frequent test timeouts. Additionally, having the unpooled allocator in the test permutations does not add very much to test coverage.
Modification:
Remove the unpooled allocator from the transport test permutation parameters.
Result:
Much faster builds, from removing the overhead of releasing millions of shared memory segments.