Expose QuicSslContextBuilder::sni (#16178)#16281
Merged
normanmaurer merged 3 commits into5.0from Feb 18, 2026
Merged
Conversation
**Motivation:**
In order to be able to receive the `SniCompletionEvent` sni mapping
needs to be used, however, the function
`QuicSslContextBuilder::buildForServerWithSni` doesn't allow setting
`ClientAuth` and alternativly the builder doesn't allow setting the SNI
mapping.
This means there is currently no way to use both SNI mapping and
support/enforce client certs with QUIC.
**Modification:**
Expose the `QuicSslContextBuilder::sni` so that its possible to create a
`QuicSslContext` with SNI mapping alongside other settings.
Also adds `QuicChannelConnectTest::testSniWithClientAuth` to validate
**Result:**
The following then works to allow both receiving the
`SniCompletionEvent` and require a client cert
```
// Build context with clientAuth and trustManager configured
QuicSslContext sniContext = QuicSslContextBuilder.forServer(key, null, cert)
.applicationProtocols("alpn/1")
.clientAuth(ClientAuth.REQUIRE)
// ...
.build();
// Create SNI-enabled context using the builder's sni() method
QuicSslContext serverContext = QuicSslContextBuilder.forServer(key, null, cert)
.clientAuth(ClientAuth.REQUIRE)
.sni(hostname -> sniContext)
.build();
```
Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In order to be able to receive the
SniCompletionEventsni mapping needs to be used, however, the functionQuicSslContextBuilder::buildForServerWithSnidoesn't allow settingClientAuthand alternativly the builder doesn't allow setting the SNI mapping.This means there is currently no way to use both SNI mapping and support/enforce client certs with QUIC.
Modification:
Expose the
QuicSslContextBuilder::sniso that its possible to create aQuicSslContextwith SNI mapping alongside other settings.Also adds
QuicChannelConnectTest::testSniWithClientAuthto validateResult:
The following then works to allow both receiving the
SniCompletionEventand require a client cert