Backport 4.1: Backport PRs must be created with personal access tokens#16277
Merged
Backport 4.1: Backport PRs must be created with personal access tokens#16277
Conversation
Motivation: When creating a PR using a workflow GITHUB_TOKEN, then no additional workflows are triggered. This means our CI build is not started on automatic backport PRs: https://docs.github.com/en/actions/concepts/security/github_token#when-github_token-triggers-workflow-runs Modification: Use a personal access token when creating the backport PR, instead of GITHUB_TOKEN. Result: Backport PRs should now have CI triggered. (cherry picked from commit ca25641)
Member
Author
|
@normanmaurer Using a personal access token does indeed let the CI builds run, but also makes it look like I posted the PR. So we should ideally get a token from the @netty-project-bot account. I don't have access to that account, but I can show you how to create it. |
Member
Let's catch up on Monday and do so ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16276 to 4.1
Cherry-picked commit: ca25641
Motivation:
When creating a PR using a workflow GITHUB_TOKEN, then no additional workflows are triggered. This means our CI build is not started on automatic backport PRs:
https://docs.github.com/en/actions/concepts/security/github_token#when-github_token-triggers-workflow-runs
Modification:
Use a personal access token when creating the backport PR, instead of GITHUB_TOKEN.
Result:
Backport PRs should now have CI triggered.