Make AdaptiveByteBuf.setBytes faster (#15736)#16048
Merged
Merged
Conversation
Motivation: The setBytes method was getting a sliced nioBuffer of its source, which typically causes allocation. On Java 16 onwards, we can instead copy using an absolutely offsetted `put` method, and forego allocating a duplicate ByteBuffer instance that is otherwise needed for isolating the position field. Modification: - Make use of the absolutely offsetted put method in setBytes, when its available. - Use the underlying ByteBuffer of the shared chunk where possible to avoid multiple bounds checks. - Add a benchmark targeting the setBytes method that takes a ByteBuf source. - Change a few benchmarks to use the default allocator when pooling is enabled. Result: Faster setBytes in certain cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The setBytes method was getting a sliced nioBuffer of its source, which typically causes allocation. On Java 16 onwards, we can instead copy using an absolutely offsetted
putmethod, and forego allocating a duplicate ByteBuffer instance that is otherwise needed for isolating the position field.Modification:
Result:
Faster setBytes in certain cases.