Use Http2Headers.size() instead of isEmpty()#13717
Merged
idelpivnitskiy merged 1 commit intonetty:4.1from Dec 5, 2023
Merged
Conversation
Motivation: grpc-java prior to version 1.59.1 does not implement `Http2Headers.isEmpty()` method (it throws `UnsupportedOperationException`). While the fix was released in 1.59.1, there is another issue with circular dependencies between `grpc-core` and `grpc-util` modules. To unblock Netty users that also depend on grpc-java, we can check the size. Modifications: - Use `Http2Headers.size()` instead of `Http2Headers.isEmpty()` in `DefaultHttp2ConnectionDecoder`; Result: Users of older grpc-java versions can independently bump Netty version.
chrisvest
approved these changes
Dec 5, 2023
Member
|
Not ideal but I guess the best we can do |
normanmaurer
approved these changes
Dec 5, 2023
Member
|
Does that mean y'all are getting bit from the Gradle side of things (grpc/grpc-java#10701)? (The other case we are aware of is Bazel, grpc/grpc-java#10576 .) The oss-licenses-plugin was related to Android, so is there another common plugin that is impacted by gradle/gradle#22850? |
Member
|
@idelpivnitskiy is the right person to answer this question :) Can you add some details ? |
Member
Author
|
Personally, I didn't try it myself, but we received concerns/hesitations from multiple projects, including gradle and bazel based. |
Member
|
Thanks. Okay. So this was a "let's not risk stuff when doing a security update." That's fair. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
grpc-java prior to version 1.59.1 does not implement
Http2Headers.isEmpty()method (it throwsUnsupportedOperationException). While the fix was released in 1.59.1, there is another issue with circular dependencies betweengrpc-coreandgrpc-utilmodules. To unblock Netty users that also depend on grpc-java, we can check the size.Modifications:
Http2Headers.size()instead ofHttp2Headers.isEmpty()inDefaultHttp2ConnectionDecoder;Result:
Users of older grpc-java versions can independently bump Netty version.