HTTP/2 don't propagate ChannelInputShutdownEvent to active streams#13395
Merged
Conversation
Motivation: Follow-up for netty#13394 to remove `ChannelInputShutdownEvent` propagation. Discussed with @Scottmitch, `ChannelInputShutdownEvent` is a premature event, most users should rely on `ChannelInputShutdownReadComplete` instead. Let's propagate only the later one and if there is a use-case for `ChannelInputShutdownEvent` we can add its propagation later. Modifications: - Remove `CHANNEL_INPUT_SHUTDOWN_EVENT_VISITOR` to stop propagation of `ChannelInputShutdownEvent`; - Adjust tests; Result: `ChannelInputShutdownEvent` is not propagated for now. We can add it back when there is a use-case.
Scottmitch
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Follow-up for #13394 to remove
ChannelInputShutdownEventpropagation. Discussed with @Scottmitch,ChannelInputShutdownEventis a premature event, most users should rely onChannelInputShutdownReadCompleteinstead. Let's propagate only the later one and if there is a use-case forChannelInputShutdownEventwe can add its propagation later.Modifications:
CHANNEL_INPUT_SHUTDOWN_EVENT_VISITORto stop propagation ofChannelInputShutdownEvent;Result:
ChannelInputShutdownEventis not propagated for now. We can add it back when there is a use-case.