Skip to content

HTTP/2 don't propagate ChannelInputShutdownEvent to active streams#13395

Merged
Scottmitch merged 1 commit into
netty:4.1from
idelpivnitskiy:cise
May 24, 2023
Merged

HTTP/2 don't propagate ChannelInputShutdownEvent to active streams#13395
Scottmitch merged 1 commit into
netty:4.1from
idelpivnitskiy:cise

Conversation

@idelpivnitskiy

Copy link
Copy Markdown
Member

Motivation:

Follow-up for #13394 to remove ChannelInputShutdownEvent propagation. Discussed with @Scottmitch, ChannelInputShutdownEvent is a premature event, most users should rely on ChannelInputShutdownReadComplete instead. Let's propagate only the later one and if there is a use-case for ChannelInputShutdownEvent we can add its propagation later.

Modifications:

  • Remove CHANNEL_INPUT_SHUTDOWN_EVENT_VISITOR to stop propagation of ChannelInputShutdownEvent;
  • Adjust tests;

Result:

ChannelInputShutdownEvent is not propagated for now. We can add it back when there is a use-case.

Motivation:

Follow-up for netty#13394 to remove `ChannelInputShutdownEvent` propagation.
Discussed with @Scottmitch, `ChannelInputShutdownEvent` is a premature
event, most users should rely on `ChannelInputShutdownReadComplete`
instead. Let's propagate only the later one and if there is a use-case
for `ChannelInputShutdownEvent` we can add its propagation later.

Modifications:

- Remove `CHANNEL_INPUT_SHUTDOWN_EVENT_VISITOR` to stop propagation of
`ChannelInputShutdownEvent`;
- Adjust tests;

Result:

`ChannelInputShutdownEvent` is not propagated for now. We can add it
back when there is a use-case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants