Skip to content

Http2ConnectionHandler#goAway should not initiate channel graceful shutdown #9207

@voidzcy

Description

@voidzcy

Introduced by #9094, in Http2ConnectionHanlder, when there is no active stream, doing GO_AWAY with error code NO_ERROR will immediately shut down the channel once the GO_AWAY frame is sent. This breaks higher layer implementation's logic of graceful shutdown, such as in gRPC. Now that the GOAWAY(<max id>), PING, PING(ACK), GOAWAY(<real id>) approach is left for higher layer implementations, graceful shutdown should not be initiated in Http2ConnectionHandler#goAway(...).

/cc @Scottmitch @ejona86 @carl-mastrangelo @dapengzhang0

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions