Add unit test

normanmaurer · normanmaurer · commit 45136e65ad18 · 2019-07-17T09:10:38.000+02:00
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexTest.java
@@ -303,6 +303,42 @@ public void channelReadShouldRespectAutoRead() {
         verifyFramesMultiplexedToCorrectChannel(childChannel, inboundHandler, 2);
     }
 
+    @Test
+    public void channelReadShouldRespectAutoReadAndNotProduceNPE() throws Exception {
+        LastInboundHandler inboundHandler = new LastInboundHandler();
+        Http2StreamChannel childChannel = newInboundStream(3, false, inboundHandler);
+        assertTrue(childChannel.config().isAutoRead());
+        Http2HeadersFrame headersFrame = inboundHandler.readInbound();
+        assertNotNull(headersFrame);
+
+        childChannel.config().setAutoRead(false);
+        childChannel.pipeline().addFirst(new ChannelInboundHandlerAdapter() {
+            private int count;
+            @Override
+            public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
+                ctx.fireChannelRead(msg);
+                // Close channel after 2 reads so there is still something in the inboundBuffer when the close happens.
+                if (++count == 2) {
+                    ctx.close();
+                }
+            }
+        });
+        frameInboundWriter.writeInboundData(childChannel.stream().id(), bb("hello world"), 0, false);
+        Http2DataFrame dataFrame0 = inboundHandler.readInbound();
+        assertNotNull(dataFrame0);
+        release(dataFrame0);
+
+        frameInboundWriter.writeInboundData(childChannel.stream().id(), bb("foo"), 0, false);
+        frameInboundWriter.writeInboundData(childChannel.stream().id(), bb("bar"), 0, false);
+        frameInboundWriter.writeInboundData(childChannel.stream().id(), bb("bar"), 0, false);
+
+        assertNull(inboundHandler.readInbound());
+
+        childChannel.config().setAutoRead(true);
+        verifyFramesMultiplexedToCorrectChannel(childChannel, inboundHandler, 3);
+        inboundHandler.checkException();
+    }
+
     @Test
     public void readInChannelReadWithoutAutoRead() {
         useReadWithoutAutoRead(false);
