typo #18
Closed
typo #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
But that's still not true, if someone doesn't use nette/reflection in his project (and it is not a dependency of nette/utils). :/
Contributor
Author
There was a problem hiding this comment.
But it's consistent with @property-read
Contributor
There was a problem hiding this comment.
So maybe fix property-read as well. :)
Contributor
There was a problem hiding this comment.
You do, this will not make code completion work properly.
Member
|
This is the only one case in framework? |
Contributor
Author
|
@dg Not sure, I wasn't searching for more broken typehints. |
Member
|
@fprochazka but have one issue for each wrong typehint is the same evil as issues for simple typos in phpdoc… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the aucompletion doesn't work.