-
-
Notifications
You must be signed in to change notification settings - Fork 151
Controls: element prototypes #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm not sure whether it is good idea to store SelectBox item prototype as Html object. Only attributes are used, more precisely, it is not HTML attributes, it is special attributes like |
|
I know it is not ideal. But Utils\Html api is well known and I didn't want to introduce a new api. |
|
Maybe Probably for consistency the same method should be added to RadioList. |
|
I thought we were talking about selectbox items, not about checkboxlist (and radiolist) labels. |
|
|
131f7d2 to
532059a
Compare
a57a557 to
55d0eb8
Compare
4ae1393 to
a9acfae
Compare
|
I've updated SelectBox and MultiSelectBox, but I think CheckboxList should have getItemLabelPrototype since the label is fully featured html element (it could have class, style...). |
|
|
CheckboxList::$itemLabelPrototype was added here #92 |
a37e424 to
6e200c4
Compare
|
Updated, failing tests are related to the nette/latte@b3b6a1d |
6e200c4 to
6b5c921
Compare
6b5c921 to
1356039
Compare
|
rebased |
|
Merged e9849ef |
|
thanks! |
CheckBoxList item label prototype:
SelectBox and MultiselectBox item prototype